Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default line length for linting #820

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Add default line length for linting #820

merged 1 commit into from
Mar 17, 2024

Conversation

scap3yvt
Copy link
Collaborator

Fixes #819

Proposed Changes

  • set the line-length parameter for black in project.toml

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions GitHub Actions
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati
sarthakpati approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati mentioned this pull request Mar 17, 2024
Merged
10 tasks
@sarthakpati sarthakpati merged commit e1d359d into mlcommons:master Mar 17, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
@scap3yvt scap3yvt deleted the 819-feature-set-line-length-for-black-in-the-projecttoml-file branch March 21, 2024 13:54
@scap3yvt scap3yvt restored the 819-feature-set-line-length-for-black-in-the-projecttoml-file branch March 21, 2024 13:54
@scap3yvt scap3yvt deleted the 819-feature-set-line-length-for-black-in-the-projecttoml-file branch March 21, 2024 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set line-length for black in the project.toml file
2 participants
@scap3yvt @sarthakpati