-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to generate split CSVs using external script #833
Added ability to generate split CSVs using external script #833
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…lit-csvs-for-trainingvalidationtesting-as-a-separate-script 828 feature add the ability to split csvs for trainingvalidationtesting as a separate script
…lit-csvs-for-trainingvalidationtesting-as-a-separate-script updated checks for stratified split
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 95.09% 95.10%
=======================================
Files 121 122 +1
Lines 8312 8347 +35
=======================================
+ Hits 7904 7938 +34
- Misses 408 409 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…lit-csvs-for-trainingvalidationtesting-as-a-separate-script 828 feature add the ability to split csvs for trainingvalidationtesting as a separate script
…lit-csvs-for-trainingvalidationtesting-as-a-separate-script 828 feature add the ability to split csvs for trainingvalidationtesting as a separate script
…ainingvalidationtesting-csv-with-proportional-splits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hey @VukW, can you give some insight on why this error is coming up? I am unable to reproduce any changes on my local system: (venv_gandlf) PS C:\Projects\GaNDLF> black .\gandlf\cli\data_split_saver.py
All done! ✨ 🍰 ✨
1 file left unchanged. |
Hi @scap3yvt , Added a fix linter requires. For local reproducing, may you check your black version matches CI one? It should be
|
Here you go: (venv_gandlf) PS C:\Projects\GaNDLF> pip show black
Name: black
Version: 23.11.0
Summary: The uncompromising code formatter.
Home-page:
Author:
Author-email: Łukasz Langa <lukasz@langa.pl>
License: MIT
Location: C:\Projects\GaNDLF\venv\Lib\site-packages
Requires: click, mypy-extensions, packaging, pathspec, platformdirs
Required-by: GANDLF |
Co-authored-by: Viacheslav Kukushkin <vy.kukushkin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #828
Proposed Changes
gandlf_splitCSV
that uses the new function from Added ability to perform stratified data splits #831 to create new splitsChecklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].