-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor chakra_converter and Add Tests #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
TaekyungHeo
force-pushed
the
pytest-converter
branch
4 times, most recently
from
May 15, 2024 01:12
992e8e6
to
03f1f8b
Compare
TaekyungHeo
force-pushed
the
pytest-converter
branch
from
May 15, 2024 01:17
03f1f8b
to
10c85e9
Compare
TaekyungHeo
changed the title
Refactor Codes and Add Tests
Refactor chakra_converter and Add Tests
May 15, 2024
Converting to draft because I am unsure whether it is acceptable to add a trace as is without using Git LFS. |
srinivas212
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. discussed offline.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
1. Pytests
2. Correlation
2.1 Run trace_link
2.2 Run et_converter
2.3 Results