Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ids to reference a field or a node. #744

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Use ids to reference a field or a node. #744

merged 6 commits into from
Sep 24, 2024

Conversation

ccl-core
Copy link
Contributor

Names are optional (so they can also not be specified). We should use ids to reference nodes.

@ccl-core ccl-core requested a review from a team as a code owner September 24, 2024 09:06
Copy link

github-actions bot commented Sep 24, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes. Thanks!!!

@ccl-core ccl-core merged commit 7574ded into main Sep 24, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants