Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 false errors from submission-checker.py #504

Closed
xgu3 opened this issue Oct 10, 2019 · 2 comments
Closed

2 false errors from submission-checker.py #504

xgu3 opened this issue Oct 10, 2019 · 2 comments

Comments

@xgu3
Copy link

xgu3 commented Oct 10, 2019

Just tried latest repo checker, and there’re 2 potential false errors.

1.ERROR:main:XXX/mobilenet/Offline/accuracy has no accuracy.txt. Generate it with accuracy-imagenet.py or accuracy-coco.py or process_accuracy.py
The rule spec doesn’t requires this accuracy.txt (only a json file is listed). The spec is here https://github.com/mlperf/policies/blob/master/submission_rules.adoc#inference

It seems the scrip expect we redirect the output of accuracy-imagenet.py to a txt file, guessing from here https://github.com/mlperf/inference/blob/master/SubmissionExample.ipynb

# accuracy run
 ./run_local.sh $@ --scenario $scenario --accuracy --output $output_dir/$scenario/accuracy
 python $cmd --mlperf-accuracy-file $output_dir/$scenario/accuracy/mlperf_log_accuracy.json \
         >  $output_dir/$scenario/accuracy/accuracy.txt
 cat $output_dir/$scenario/accuracy/accuracy.txt

So which one is correct, the rules or the script?

2.ERROR:main:XXX/resnet/Server/accuracy has file list mismatch ([u'mlperf_log_detail.txt', u'mlperf_log_summary.txt', u'accuracy.txt'])
It seems the script is looking for mlperf_log_detail.txt and mlperf_log_summary.txt, but per the rules, those 2 files shall be under /performance, like below,

performance/
•	run_x/ # 1 run for single stream and offline, 5 otherwise
o	mlperf_log_summary.txt
o	mlperf_log_detail.txt
o	mlperf_log_trace.json

I think the script shall be modified to follow rule spec.

And one more question, the rule requires compliance_checker_log.txt, is this just redirecting the output of submission-checker.py to a txt file?

@christ1ne @schmuell @guschmue

@aaronzhongii
Copy link
Contributor

I raised the same question before as in #473 (comment)

But I think these are minor file adjustment issues. And Vijay has asked Peter to change the rule accordingly in last meeting.

@schmuell
Copy link
Contributor

schmuell commented Oct 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants