Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPT-J rules #275

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add GPT-J rules #275

merged 1 commit into from
Jul 5, 2023

Conversation

pgmpablo157321
Copy link
Contributor

No description provided.

@pgmpablo157321 pgmpablo157321 requested a review from a team as a code owner June 21, 2023 20:21
@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@pgmpablo157321 pgmpablo157321 changed the title Add GPT-J rules [WIP] Add GPT-J rules Jun 21, 2023
@rnaidu02
Copy link
Contributor

@pgmpablo157321 Accuracy and latency details look good. Can you add beam=4 also to the details in the rules document for GPT-J?

@pgmpablo157321 pgmpablo157321 changed the title [WIP] Add GPT-J rules Add GPT-J rules Jun 27, 2023
@pgmpablo157321
Copy link
Contributor Author

@rnaidu02 Does this look ok to you?https://github.com/mlcommons/inference_policies/blob/87b3958b2df37b704a6397a5c8ee6761e90aeeb9/inference_rules.adoc#additional-inference-parameters

@rnaidu02
Copy link
Contributor

LGTM

@liorkhe liorkhe mentioned this pull request Jul 4, 2023
Closed
@mrmhodak mrmhodak merged commit 658b490 into master Jul 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrmhodak mrmhodak mrmhodak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgmpablo157321 @rnaidu02 @mrmhodak