Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter rcp_bypass should cover case where RCP is missing #213

Closed
emizan76 opened this issue Mar 16, 2022 · 1 comment
Closed

Parameter rcp_bypass should cover case where RCP is missing #213

emizan76 opened this issue Mar 16, 2022 · 1 comment
Assignees

Comments

@emizan76
Copy link
Contributor

Right now we allow rcp_bypass to help a failed RCP checker pass only when the RCP is found.

An RCP is NOT found when
(i) The submission batch size is larger than the max batch size of RCPs OR
(ii) The submission batch size is smaller than the min batch size of RCPs and submission convergence in epochs/samples is faster than the RCP faster convergence.

In these two cases the submitter is required to submit a new RCP to match their submission.

Since these RCP submissions typically happen at submission time, and now we will use an automatic script to accept/reject submissions, we have decided to allo rcp_bypass to include the above NOT found cases. So instead of failing the check and asking for the submitter to provide for a new RCP, the submission will pass and at review period the committee will make sure the submitter has submitted the missing RCP at submission time.

@emizan76 emizan76 self-assigned this Apr 1, 2022
emizan76 added a commit that referenced this issue Apr 7, 2022
@emizan76
Copy link
Contributor Author

emizan76 commented Apr 7, 2022

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant