Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNN-T] RCPs update - disabled bucketing #146

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Conversation

mwawrzos
Copy link
Contributor

@mwawrzos mwawrzos commented Jul 5, 2021

refers to mlcommons/training_policies#453

1k and 3k update TBD

@github-actions
Copy link

github-actions bot commented Jul 5, 2021

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@mwawrzos mwawrzos changed the title [RNN-T] RCPs update - disabled bucketing 2k [RNN-T] RCPs update - disabled bucketing Jul 5, 2021
@mwawrzos mwawrzos requested a review from qpjaada July 5, 2021 19:24
@qpjaada
Copy link

qpjaada commented Jul 6, 2021

@mwawrzos - not sure what the policy is - but shouldn't the 1.0.0 RCPs stay unchanged?
I think this should be updated only for the 1.1.0 RCPs.....

@mwawrzos
Copy link
Contributor Author

mwawrzos commented Jul 7, 2021

Sure.. my bad.. thanks, fixed

@qpjaada
Copy link

qpjaada commented Jul 9, 2021

what's the plan for updating the RCPs for BS=1024, 3072? I presume we need to generate RCPs for that with data_train_num_buckets=1. At a minimum, it would be useful to create an issue that keeps track of this.

@mwawrzos
Copy link
Contributor Author

I can update the numbers in August, as I'm on vacation now. I opened an issue here: #147

Copy link

@qpjaada qpjaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mwawrzos mwawrzos marked this pull request as ready for review August 19, 2021 10:28
@xyhuang xyhuang merged commit 22c5167 into mlcommons:master Sep 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants