-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trivial fix to the melt procedure + corresponding test #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket #? |
Pas de ticket. C'est un bug trivial :P Je me suis dit tant qu'à l'ouvrir dans notre confluence legacy... |
Trivial ou non, ça aide Frank pour les releases notes. Ticket stp.
2017-02-14 13:33 GMT-05:00 Simon Lemieux <notifications@github.com>:
… Pas de ticket. C'est un bug trivial :P
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#850 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlFTn7nJ-pfhMSEWljNff4CyDwbxc4Mks5rcfNdgaJpZM4MA0MO>
.
|
FinchPowers
reviewed
Feb 14, 2017
@@ -3,14 +3,14 @@ | |||
# Francois Maillet, 2016-01-24 | |||
# This file is part of MLDB. Copyright 2016 mldb.ai inc. All rights reserved. | |||
# | |||
import datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket pour ça??
FinchPowers
reviewed
Feb 14, 2017
import json | ||
|
||
mldb = mldb_wrapper.wrap(mldb) # noqa | ||
|
||
def assert_val(res, row_name, col_name, value): | ||
for row in res: | ||
if str(row["rowName"]) != row_name: continue | ||
if str(row["rowName"]) != row_name: | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tu charies...
FinchPowers
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.