Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing XX from suffixes #425

Merged
merged 1 commit into from
Aug 17, 2021
Merged

fix: Removing XX from suffixes #425

merged 1 commit into from
Aug 17, 2021

Conversation

martinheidegger
Copy link
Contributor

I noticed that the suffixes of Kazakhstan and Russia both had XX suffix in the idd property. This seems odd as all other suffixes are only numbers. This PR removes the XX from those suffixes.

Note: I havn't figured out how to compile using the countries.php file and so this PR only contains the changes in the main .json file. Sorry about that.

@mledoze
Copy link
Owner

mledoze commented Aug 17, 2021

Hi, thank you for this. Could you please add an entry in the changelog?

Note: I havn't figured out how to compile using the countries.php file and so this PR only contains the changes in the main .json file. Sorry about that.

No worries. You need to install the project dependencies with Composer and run the command php countries.php convert to generate the dist files. If you can't do it, I'll handle that before the next release.

@martinheidegger
Copy link
Contributor Author

Thank you for taking care of the composer task.

I added a changelog entry in ef2f33f

@mledoze mledoze merged commit a3e6e41 into mledoze:master Aug 17, 2021
@mledoze
Copy link
Owner

mledoze commented Aug 17, 2021

It's merged now! 👍🏼

@martinheidegger martinheidegger deleted the remove-xx-suffix branch August 17, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants