CommunityModel improvements #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
ShadowJonathan and
EricBAndrews
and removed request for
a team
EricBAndrews
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Nice!
Couple small change requests, largest one is around updating state-faked values after the API call either succeeds or returns. Per Slack and Inbox Middleware PR, that logic might look a little nicer if we convert this to an ObservableObject class, but should be super easy to port in the future if we decide to do that
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
EricBAndrews
approved these changes
Oct 27, 2023
boscojwho
pushed a commit
that referenced
this pull request
Nov 23, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleshed out
CommunityModeland changed the type of thePostModel.communityproperty fromAPICommunity->CommunityModel.