Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Default Icon, Organized App Icons #736

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - list issue(s) here
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

About this Pull Request

This PR adds Sjmarf's new Stargazer icon and sets it as the default app icon.

It also organizes the icons display so that icons are now grouped by creator in disclosure groups:

Screenshot 2023-10-30 at 10 56 45 PM Screenshot 2023-10-30 at 10 56 49 PM

To support this, I have lightly refactored AlternativeIcon structs.

@EricBAndrews EricBAndrews requested a review from a team as a code owner October 31, 2023 03:47
@EricBAndrews EricBAndrews requested review from WestonHanners and ShadowJonathan and removed request for a team October 31, 2023 03:47
Copy link
Contributor

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe a 'navigationTitle on this menu would be nice?

@EricBAndrews EricBAndrews merged commit 971cd00 into dev Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants