Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bosco/xcode previews search tab #741

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

boscojwho
Copy link
Contributor

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

About this Pull Request

Developer Tooling - Adds Xcode 15 #Previews to all views in /Search directory:

  • Previews use a wrapper view suffixed with Preview. This workarounds bug where @variables defined inside #Preview closure don't work (they're suppose to work).
  • Views that expect a result from server simply show no results/empty state.

Next Steps:

  • Add mock data for list results.

Additional Context

Any additional context you'd like to add to help us review this PR

@boscojwho boscojwho requested a review from a team as a code owner November 2, 2023 00:49
@boscojwho boscojwho requested review from WestonHanners and mormaer and removed request for a team November 2, 2023 00:49
@boscojwho boscojwho merged commit 7edac48 into dev Nov 2, 2023
4 checks passed
@boscojwho boscojwho deleted the bosco/xcode-previews-search-tab branch November 2, 2023 19:15
boscojwho added a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants