Fixed some inbox problems, tweaked haptics #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
JakeShirley and
mormaer
and removed request for
a team
Sjmarf
approved these changes
Nov 8, 2023
EricBAndrews
force-pushed
the
eric/inbox-refinements
branch
from
e484c8e
to
03e8a3a
Compare
boscojwho
pushed a commit
that referenced
this pull request
Nov 23, 2023
(cherry picked from commit b91d4e5)
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Follow-up to Generic Multi-Trackers, Inbox Middleware #726
Pull Request Information
This PR addresses an issue created by #726 where haptics were playing twice on votes.
It also fixes an issue where marking mentions and replies as read was causing the view to hitch while the
unreadTrackerupdates;unreadTrackeris now not updated until after a successful API call. This introduces a little bit of lag between the state fake and the unread badge state, but is substantially smoother on the swipe.It also performs some minor haptic adjustments: