Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eric/0.19 account deletion #753

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Eric/0.19 account deletion #753

merged 4 commits into from
Nov 11, 2023

Conversation

EricBAndrews
Copy link
Member

Checklist

Pull Request Information

This PR enables deletion of content during account deletion on instances running 0.19.0 or above.

It also makes the account deletion flow scarier and harder to accidentally execute:

Screenshot 2023-11-09 at 4 10 19 PM Screenshot 2023-11-09 at 4 10 23 PM

@EricBAndrews EricBAndrews requested a review from a team as a code owner November 9, 2023 21:15
@EricBAndrews EricBAndrews requested review from JakeShirley and mormaer and removed request for a team November 9, 2023 21:15
Copy link
Contributor

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

Mlem/API/APIClient/APIClient.swift Outdated Show resolved Hide resolved
@EricBAndrews EricBAndrews merged commit adf639e into dev Nov 11, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/0.19-account-deletion branch November 11, 2023 22:42
boscojwho pushed a commit that referenced this pull request Nov 23, 2023
(cherry picked from commit adf639e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.19.0] Allow deletion of user content during account removal
2 participants