fixed sort resetting when navigating back from a post #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
JakeShirley and
mormaer
and removed request for
a team
|
What's the repro for this? I tried the following on the latest
B.
|
|
Repro steps (produces bug behavior on build 749):
|
EricBAndrews
force-pushed
the
eric/sort-reset-fix
branch
from
d33aa47
to
2ef5c5b
Compare
boscojwho
pushed a commit
that referenced
this pull request
Nov 23, 2023
(cherry picked from commit e29b179)
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- closes Community forgets navigation #750
Pull Request Information
This PR fixes the community reloading when navigating back from a post. It introduces a state variable to track whether the site information has loaded. Posts are now not displayed until site information has loaded to avoid a jarring redraw if the sort type is updated, and the sort type uses this variable to ensure it only updates the sort information the first time site information loads.