Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.19 Post Compatibility #759

Merged
merged 5 commits into from
Nov 12, 2023
Merged

0.19 Post Compatibility #759

merged 5 commits into from
Nov 12, 2023

Conversation

EricBAndrews
Copy link
Member

Checklist

Pull Request Information

This PR enables 0.19 compatibility for posts:

  • Adds cursor pagination (based on @mormaer's cursor pagination branch)
  • Updates some models for 0.19 compatibility:
    • APIPostAggregates now lists fields not present in 0.19 as optional
    • APIPostView now has an optional creatorIsModerator field

@EricBAndrews EricBAndrews requested a review from a team as a code owner November 11, 2023 21:09
@EricBAndrews EricBAndrews requested review from WestonHanners and JakeShirley and removed request for a team November 11, 2023 21:09
Sjmarf
Sjmarf approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Mlem/API/Models/Posts/APIPostView.swift Show resolved Hide resolved
@EricBAndrews EricBAndrews mentioned this pull request Nov 12, 2023
Closed
@EricBAndrews EricBAndrews enabled auto-merge (squash) November 12, 2023 17:43
@EricBAndrews EricBAndrews merged commit 57af347 into dev Nov 12, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/0.19-post-decoding branch November 12, 2023 18:02
boscojwho pushed a commit that referenced this pull request Nov 23, 2023
@EricBAndrews @boscojwho
0.19 Post Compatibility (#759)
0b202ad 
Co-authored-by: mormaer <nick@mormaer.dev>
(cherry picked from commit 57af347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sjmarf Sjmarf Sjmarf approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0.19] Post decoding errors [0.19.0] - Cursor based pagination
3 participants
@EricBAndrews @Sjmarf @mormaer