Double Tap for Scroll to Top #764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is working - Added some animations for now, to be improved
schmeat
requested review from
mormaer and
EricBAndrews
and removed request for
a team
|
Thank you for the PR! I'm closing this because we have a bunch of infrastructure in place already to support this feature and so don't want to merge a second parallel implementation, but we truly appreciate your contribution. We know this is a super highly requested feature, so we've bumped development priority aggressively and are hoping to have it in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- N/A
Pull Request Information
About this Pull Request
Adding functionality that scrolls to the top of the feed when a user double clicks the feed button. Just wanted to add it because it's a feature I miss when using Apollo. It's also a way to for me to get more into swiftUI.
The animations are a bit bare bones right now but wanted to get feedback on this before I proceed further.
Note: This currently fails swift lint's
type_body_lengthrule since it adds 10 lines of code and the body is already at the max (250). Not sure if that would be open to changing as it does seem a bit restrictive in my opinion.Screenshots and Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-15.at.11.17.45.mp4
Additional Context
Bulk of the "changes" is me adding a ScrollViewReader and state tracker for double clicking the button. Please let me know if you need additional information.