Borrowed Ice Cubes Image Viewer #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners and
JakeShirley
and removed request for
a team
EricBAndrews
changed the title
boscojwho
pushed a commit
that referenced
this pull request
Nov 23, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Slack
Pull Request Information
This PR fixes an issue where the quicklook image view was very slow to appear. I have replaced that viewer with the one used in Ice Cubes for Mastodon, with some modifications:
Screen.Recording.2023-11-15.at.7.37.31.PM.mov
It supports pinch-to-zoom!
Screen.Recording.2023-11-15.at.7.43.17.PM.mov
The old quicklook view is now available from the context menu on the image:
Screen.Recording.2023-11-15.at.7.38.15.PM.mov
And you can save to photos directly from that context menu, too:
Screen.Recording.2023-11-15.at.7.40.14.PM.mov