Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fediseer Integration #900

Merged
merged 121 commits into from
Feb 26, 2024
Merged

Fediseer Integration #900

merged 121 commits into from
Feb 26, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Feb 4, 2024

Added a "Trust & Safety" tab to InstanceView, which displays information from the Fediseer. The user can view the endorsements, hesitations and censures received by an instance. This is useful for gauging the legitimacy of an instance.

This isn't a full implementation of everything Fediseer offers. Notably, you can't see a list of endorsements/hesitations/censures that an instance has given to another instance, and you can't create endorsements/hesitations/censures as an instance administrator. I don't plan to implement either of these in the near future, but it's something we could consider down the road.

@Sjmarf Sjmarf marked this pull request as ready for review February 16, 2024 13:34
@Sjmarf Sjmarf requested a review from a team as a code owner February 16, 2024 13:34
@Sjmarf Sjmarf requested review from JakeShirley and mormaer and removed request for a team February 16, 2024 13:34
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Left some notes on wording, open to further workshopping.

Tab navigation also appears to be missing from the Endorsements and Instance pages.

It might be worth adding a No reason given entry under these--I sort of expected them to be disclosure groups.

Screenshot 2024-02-23 at 5 42 34 PM

Mlem/Views/Shared/Instance/InstanceView+Logic.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/InstanceView+Logic.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/InstanceView+Logic.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/FediseerInfoView.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/FediseerInfoView.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/FediseerInfoView.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/FediseerInfoView.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/FediseerInfoView.swift Outdated Show resolved Hide resolved
Mlem/Views/Shared/Instance/FediseerInfoView.swift Outdated Show resolved Hide resolved
Sjmarf and others added 8 commits February 23, 2024 22:44
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sjmarf Sjmarf enabled auto-merge (squash) February 26, 2024 16:57
@Sjmarf Sjmarf merged commit 4a9179f into dev Feb 26, 2024
4 checks passed
@Sjmarf Sjmarf deleted the sjmarf/instance-fediseer branch February 26, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants