[DOC][MINOR] Added step for dev env setup #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vilmos Agoston <vilmos.agoston@gmail.com>
github-actions
bot
added
area/docs
harupy
reviewed
Jul 14, 2021
CONTRIBUTING.rst
Outdated
| @@ -149,6 +149,7 @@ If you plan on doing development and testing, you will also need to install the | |||
| pip install -r dev-requirements.txt | |||
| pip install -r test-requirements.txt | |||
| pip install -e .[extras] # installs mlflow from current checkout | |||
| pip install -e tests/resources/mlflow-test-plugin # installs an mlflow plugin for tests | |||
There was a problem hiding this comment.
Suggested change
| pip install -e tests/resources/mlflow-test-plugin # installs an mlflow plugin for tests | |
| pip install -e tests/resources/mlflow-test-plugin # installs `mlflow-test-plugin` that is required for running MLflow plugin tests |
Can we fix the comment to clarify why we need to install mlflow-test-plugin?
There was a problem hiding this comment.
@harupy Cheers. The thing is that this plugin is required for a lot of tests, not just plugin tests, e.g.
mlflow/tests/deployments/test_cli.py
Line 15 in f7dda6e
I'll clarify the why part in the comment though.
There was a problem hiding this comment.
@vagoston You're right! Thanks for the update!
Signed-off-by: Vilmos Agoston <vilmos.agoston@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vilmos Agoston vilmos.agoston@gmail.com
What changes are proposed in this pull request?
Minor change in setting up the dev env
How is this patch tested?
local tests pass
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/docs: MLflow documentation pagesrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section