Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CHANGELOG.rst to markdown #5455

Merged
merged 5 commits into from
Mar 8, 2022

Conversation

harupy
Copy link
Member

@harupy harupy commented Mar 4, 2022

Signed-off-by: harupy 17039389+harupy@users.noreply.github.com

What changes are proposed in this pull request?

Convert CHANGELOG.rst to markdown.

Motivation

  • To make it easier to automate creating the following when releasing a new version of MLflow:
    • A release post on GitHub.
    • A news post on mlflow.org.
  • Markdown can be formatted using prettier.
  • Many code editors support previewing markdown.
  • Markdown is easier to write than reStructuredText.

Follow-up tasks

  • Update our internal Jenkins job that udpates CHANGELOG.
  • (Optional) Add a GitHub Actions workflow to lint markdowns using prettier in the repository.

How is this patch tested?

Manual verification.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Mar 4, 2022
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy force-pushed the convert-changelog-to-markdown branch from 5887e4e to 0fda395 Compare March 4, 2022 15:29
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
CHANGELOG.md Outdated
Comment on lines 1066 to 1045
- [Python][CLI] Mark ``azureml.build_image`` as experimental (#1222, #1233 @sueann)
- [Projects] Fix bug not sharing `SQLite` database file with Docker container (#1347, @tomasatdatabricks; #1375, @aarondav)
- [Java] Mark `sendPost` and `sendGet` as experimental (#1186, @aarondav)
- [Python][cli] Mark `azureml.build_image` as experimental (#1222, #1233 @sueann)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier automatically lower-cases link keys:
prettier/prettier#7118

Copy link
Member Author

@harupy harupy Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way to prevent this is to wrap the tag with backticks:

`[Python][CLI]` Mark ...

or avoid using the [A][B] syntax:

[Python/CLI]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so let's change it back to [CLI] ?

Copy link
Member Author

@harupy harupy Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeichenXu123 If we use [Python][CLI], we can't apply auto-formatting with prettier, which I think is incovenient.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. I think using either [Python][CLI] or [Python/CLI] is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the hybridized [Python/<PascalCase/camelcase>] as needed so that link references are consistent and legible.

Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some small format issues

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harupy harupy merged commit 62d625b into mlflow:master Mar 8, 2022
erensahin pushed a commit to erensahin/mlflow that referenced this pull request Apr 11, 2022
* Convert CHANGELOG.rst to markdown

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix link

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix formatting

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix cross_val

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix link keys

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants