-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added autologging of input example and signature for tf.estimator and keras fit_generator #5510
Added autologging of input example and signature for tf.estimator and keras fit_generator #5510
Conversation
Autologging of input example/signature for tf.estimator Autologging of input example/signature for fit_generator for keras Cleanup of log models inside keras callback Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
… anymore Signed-off-by: Jas Bali <bali0019@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bali0019 Awesome stuff! Thanks for contributing this! I left a few comments, mostly code structure / readability nits and some questions for my own understanding.
Additional minor fixes for PR reviews around code formatting, docstrings, etc Signed-off-by: Jas Bali <bali0019@gmail.com>
…ut-example-signature-keras-fixes � Conflicts: � mlflow/tensorflow/__init__.py Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
…is set to True Signed-off-by: Jas Bali <bali0019@gmail.com>
… a util function inside _autolog.py Signed-off-by: Jas Bali <bali0019@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bali0019 This is looking fantastic! After the remaining small comments are addressed, this will be ready for merge!
…od names for tf input example extraction Signed-off-by: Jas Bali <bali0019@gmail.com>
…n exception when input example is None Signed-off-by: Jas Bali <bali0019@gmail.com>
…d types Added unit tests to assert None is returned for unsupported types for these functions) Signed-off-by: Jas Bali <bali0019@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much, @bali0019 ! Let's resolve two small spacing comments, then I'll go ahead and merge :)
Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali bali0019@gmail.com
What changes are proposed in this pull request?
Autologging of input example/signature for tf.estimator
Autologging of input example/signature for fit_generator for keras
Cleanup of log models inside keras callback
How is this patch tested?
Unit tests
Does this PR change the documentation?
ci/circleci: build_doc
check. If it's successful, proceed to thenext step, otherwise fix it.
Details
on the right to open the job page of CircleCI.Artifacts
tab.docs/build/html/index.html
.Release Notes
Is this a user-facing change?
Added autologging of input example and signature for tf.estimator and keras fit_generator
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes