Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autologging of input example and signature for tf.estimator and keras fit_generator #5510

Merged

Conversation

bali0019
Copy link
Contributor

@bali0019 bali0019 commented Mar 17, 2022

Signed-off-by: Jas Bali bali0019@gmail.com

What changes are proposed in this pull request?

Autologging of input example/signature for tf.estimator
Autologging of input example/signature for fit_generator for keras
Cleanup of log models inside keras callback

How is this patch tested?

Unit tests

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Added autologging of input example and signature for tf.estimator and keras fit_generator

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Autologging of input example/signature for tf.estimator
Autologging of input example/signature for fit_generator for keras
Cleanup of log models inside keras callback

Signed-off-by: Jas Bali <bali0019@gmail.com>
@bali0019 bali0019 changed the title Added autologging of input example and signature for tf.estimator Added autologging of input example and signature for tf.estimator and keras fit_generator Mar 17, 2022
@github-actions github-actions bot added area/models MLmodel format, model serialization/deserialization, flavors rn/feature Mention under Features in Changelogs. labels Mar 17, 2022
Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
… anymore

Signed-off-by: Jas Bali <bali0019@gmail.com>
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bali0019 Awesome stuff! Thanks for contributing this! I left a few comments, mostly code structure / readability nits and some questions for my own understanding.

Additional minor fixes for PR reviews around code formatting, docstrings, etc

Signed-off-by: Jas Bali <bali0019@gmail.com>
…ut-example-signature-keras-fixes

� Conflicts:
�	mlflow/tensorflow/__init__.py

Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
Signed-off-by: Jas Bali <bali0019@gmail.com>
…is set to True

Signed-off-by: Jas Bali <bali0019@gmail.com>
… a util function inside _autolog.py

Signed-off-by: Jas Bali <bali0019@gmail.com>
mlflow/keras.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bali0019 This is looking fantastic! After the remaining small comments are addressed, this will be ready for merge!

…od names for tf input example extraction

Signed-off-by: Jas Bali <bali0019@gmail.com>
…n exception when input example is None

Signed-off-by: Jas Bali <bali0019@gmail.com>
…d types

Added unit tests to assert None is returned for unsupported types for these functions)

Signed-off-by: Jas Bali <bali0019@gmail.com>
mlflow/keras.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much, @bali0019 ! Let's resolve two small spacing comments, then I'll go ahead and merge :)

Signed-off-by: Jas Bali <bali0019@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/models MLmodel format, model serialization/deserialization, flavors rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants