-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement issue-5501 - add mlflow_version info to logged model #5515
Conversation
Oops, I just noticed that |
Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com>
Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com> Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com>
Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r3stl355 Looks great! LGTM once remaining comments have been addressed!
Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com>
Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition! LGTM!
…w#5515) * implement issue-5501 Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com> * assure existing tests pass Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com> * Update tests/models/test_model.py Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com> Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com> * do not set mlflow_version for models loaded from older format Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com> * move mlflow_version attribute name to constant Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com> * move mlflow_version removal on safe to to_dict Signed-off-by: Nikolay Ulmasov <ulmasov@hotmail.com> Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Nikolay Ulmasov ulmasov@hotmail.com
What changes are proposed in this pull request?
Implement issue #5501 - Add an mlflow_version field to the MLModel spec that is automatically populated with the current MLflow version when an MLflow Model is saved / logged.
Models logged with previous versions will have
mlflow_version=None
when loaded from a file.How is this patch tested?
Extended existing tests and added a test to load previously logged models without mlflow_version info
Does this PR change the documentation?
ci/circleci: build_doc
check. If it's successful, proceed to thenext step, otherwise fix it.
Details
on the right to open the job page of CircleCI.Artifacts
tab.docs/build/html/index.html
.Release Notes
Is this a user-facing change?
Users can check the version of MLFlow the model with logged with.
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes