-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set timezone to UTC in windows #5538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
changed the title
Diable Daylight Saving time adjustments in windows
Disable Daylight Saving time adjustments in windows
Mar 28, 2022
harupy
changed the title
Disable Daylight Saving time adjustments in windows
Set timezone to UTC in windows
Mar 28, 2022
harupy
commented
Mar 28, 2022
@@ -5,7 +5,7 @@ module.exports = () => { | |||
// On windows, the timezone is not set with `TZ=GMT`. As a workaround, use `tzutil`. | |||
// This approach is taken from https://www.npmjs.com/package/set-tz. | |||
if (os.platform() === 'win32') { | |||
const TZ = 'GMT Standard Time'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GMT Standard Time
(which is not GMT
) represents the timezone containing Dublin, Edinburgh, Lisbon, London and adjusts for DST.
dbczumar
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @harupy !
vvijay-bolt
pushed a commit
to vvijay-bolt/mlflow
that referenced
this pull request
Mar 30, 2022
* Diable Daylight Saving time adjustments in windows Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use utc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com>
vvijay-bolt
pushed a commit
to vvijay-bolt/mlflow
that referenced
this pull request
Mar 30, 2022
* Diable Daylight Saving time adjustments in windows Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use utc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com>
vvijay-bolt
pushed a commit
to vvijay-bolt/mlflow
that referenced
this pull request
Mar 30, 2022
* Diable Daylight Saving time adjustments in windows Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use utc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com>
vvijay-bolt
pushed a commit
to vvijay-bolt/mlflow
that referenced
this pull request
Mar 30, 2022
* Diable Daylight Saving time adjustments in windows Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use utc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com>
erensahin
pushed a commit
to erensahin/mlflow
that referenced
this pull request
Apr 11, 2022
* Diable Daylight Saving time adjustments in windows Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use utc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
BenWilson2
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Refactor files in `tests/db` to allow running tests in repository root (#5513) * rename postgres.schema Signed-off-by: harupy <hkawamura0130@gmail.com> * Refactor database tests Signed-off-by: harupy <hkawamura0130@gmail.com> * remove import sqlalchemy Signed-off-by: harupy <hkawamura0130@gmail.com> * fix docker-compose down Signed-off-by: harupy <hkawamura0130@gmail.com> * update Signed-off-by: harupy <hkawamura0130@gmail.com> * fix lint failures Signed-off-by: harupy <hkawamura0130@gmail.com> * blacken Signed-off-by: harupy <hkawamura0130@gmail.com> * more fixes Signed-off-by: harupy <hkawamura0130@gmail.com> * add tests/db/compose.sh Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * rename Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use compose v2 Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove grep Signed-off-by: harupy <hkawamura0130@gmail.com> * run command using exec Signed-off-by: harupy <hkawamura0130@gmail.com> * set --no-TTY Signed-off-by: harupy <hkawamura0130@gmail.com> * specify image and remove redundant build arg Signed-off-by: harupy <hkawamura0130@gmail.com> * fix workflow Signed-off-by: harupy <hkawamura0130@gmail.com> * improve README Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Append user agent added by request_header_provider to default user agent (#5502) * User agent added by request_header_plugin gets appended to default user agent Signed-off-by: singankit <anksing@microsoft.com> * Adding large marker following similar test with the marker Signed-off-by: singankit <anksing@microsoft.com> * Appending headers from various request_header_providers Signed-off-by: singankit <anksing@microsoft.com> * Review comments to use dict method Signed-off-by: singankit <anksing@microsoft.com> * Adding default request header provider Signed-off-by: singankit <anksing@microsoft.com> * Fixing typo in test Signed-off-by: singankit <anksing@microsoft.com> * Fixing rest_utils test Signed-off-by: singankit <anksing@microsoft.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * use schema when parsing csv Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Use split (#5522) Signed-off-by: dbczumar <corey.zumar@databricks.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Fix issue #2804 - Set run name in MLProject execution (#5187) * Add mlflow run name to projects.run() Signed-off-by: bramrodenburg <14278376+bramrodenburg@users.noreply.github.com> * Renamed MLFLOW_RUN_NAME to RUN_NAME in CLI metavars Signed-off-by: bramrodenburg <14278376+bramrodenburg@users.noreply.github.com> * Update CLI docstring * Address feedback * Autoformat: https://github.com/mlflow/mlflow/actions/runs/2031948113 Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com> Co-authored-by: Corey Zumar <39497902+dbczumar@users.noreply.github.com> Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Restoring virtual python environment for mlflow pyfunc spark_udf (#5487) * init Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * debug ci Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * black Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * fix tests Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * fix test Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Set timezone to UTC in windows (#5538) * Diable Daylight Saving time adjustments in windows Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use utc Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * init (#5532) Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * feat: pyspark autologging enhancement (#5481) * feat: general support for autologging models containing parameters of type Param and fix some comments Signed-off-by: Xinyue Ruan <serena.rxy@gmail.com> * fix format Signed-off-by: Xinyue Ruan <serena.rxy@gmail.com> * fix jinja2 import error Signed-off-by: Xinyue Ruan <serena.rxy@gmail.com> * update function doc Signed-off-by: Xinyue Ruan <serena.rxy@gmail.com> * add Evaluator type param into testcase Signed-off-by: Xinyue Ruan <serena.rxy@gmail.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Fix invalid Anaconda URLs (#5547) Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Use latest version of black fo fix lint check (#5548) * Use latest version of black Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * run black Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * test for csv parsing Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Removing the mention of tf1. (#5552) Removing the mention of tf1 since this directory mentions the examples of using tf2. For users on TF1, use the migration guide: https://www.tensorflow.org/guide/migrate Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Run `test_sqlalchemy_store.py` against PostgreSQL, MySQL, and MSSQL (#5540) * run test_sqlalchemy_store Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use IS NULL Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * rename test classes Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix like operation Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use method Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use constants Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use LIKE before LIKE BINARY Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use Japanese_Bushu_Kakusu Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove _UTF8 Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * reset experiment_id Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Make tensorflow model prediction support array type input (#5545) * init Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * add test Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Removed utility function, use zip Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Implement function to get MLflow pyfunc model dependencies (#5503) * init Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * init Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update doc Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * split test Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * refactor Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> * update Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * replace universal_newlines with text (#5557) Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Fix #5551 - PyTorch LightningDeprecationWarning ModelSummary and get_gpu_memory_map (#5559) * Fix #5551 - PyTorch LightningDeprecationWarning ModelSummary and get_gpu_memory_map Signed-off-by: Bruno Cabado Lousa <sr.brunocabado@gmail.com> * Fix version check Signed-off-by: Bruno Cabado Lousa <sr.brunocabado@gmail.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Pin `click` to fix spacy tests (#5560) * pin click Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add spacy as extra dependency Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * pin flask Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Add default experiment ID provider for repo notebooks (#5449) Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Add feature to set and delete description of a run. (#5534) * Add feature to set and delete description of a run. Signed-off-by: Albert Chung <albertswchung@gmail.com> * Add edge case handling when run description is set twice, add tests for each scenario. Signed-off-by: Albert Chung <albertswchung@gmail.com> * Throw INVALID_PARAMETER_VALUE error code when setting description twice. Signed-off-by: Albert Chung <albertswchung@gmail.com> Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * revert change to json utils Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * revert change to json utils Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * Autoformat: https://github.com/mlflow/mlflow/actions/runs/2091247297 Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com> * move string io Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * remove file Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> * remove files Signed-off-by: Varun Kumar Vijay <vvijay@bolt.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Co-authored-by: Ankit Singhal <30610298+singankit@users.noreply.github.com> Co-authored-by: Corey Zumar <39497902+dbczumar@users.noreply.github.com> Co-authored-by: bramrodenburg <14278376+bramrodenburg@users.noreply.github.com> Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com> Co-authored-by: WeichenXu <weichen.xu@databricks.com> Co-authored-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com> Co-authored-by: Vini Jaiswal <vini.js1303@gmail.com> Co-authored-by: Bruno Cabado <Kr4is@users.noreply.github.com> Co-authored-by: apurva-koti <51172624+apurva-koti@users.noreply.github.com> Co-authored-by: Albert <albertswchung@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy 17039389+harupy@users.noreply.github.com
What changes are proposed in this pull request?
Set timezone to UTC in windows to prevent DST from breaking tests:
https://github.com/mlflow/mlflow/runs/5713170779?check_suite_focus=true#step:9:1249
GMT is 1 hour ahead of UTC due to British Summer Time (BST) that started today.
How is this patch tested?
Existing tests
Does this PR change the documentation?
ci/circleci: build_doc
check. If it's successful, proceed to thenext step, otherwise fix it.
Details
on the right to open the job page of CircleCI.Artifacts
tab.docs/build/html/index.html
.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes