Fix r job broken by R 4.2.0
#5763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <hkawamura0130@gmail.com>
github-actions
bot
added
area/build
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
harupy
changed the title
libharfbuzz-dev and libfribidi-dev to fix r jobr job broken by R 4.2.0
harupy
commented
Apr 24, 2022
| mlflow_predict(model_reloaded, iris[, 1:4])) | ||
| ) |
There was a problem hiding this comment.
Fix for:
https://github.com/mlflow/mlflow/runs/6146011996?check_suite_focus=true#step:11:836
── Error (test-keras-model.R:29:3): mlflow can save keras model ───────────────
Error in `all.equal.numeric(x, y, tolerance = tolerance, check.attributes = check.attributes,
...)`: length(tolerance) == 1L is not TRUE
harupy
commented
Apr 25, 2022
| @@ -63,14 +63,18 @@ def serve( | |||
| _execute(command) | |||
|
|
|||
| def can_score_model(self): | |||
| # `Rscript --version` writes to stderr in R < 4.2.0 but stdout in R >= 4.2.0. | |||
There was a problem hiding this comment.
Related commit: wch/r-source@35cc16f
dbczumar
reviewed
Apr 26, 2022
mlflow/R/mlflow/Dockerfile.dev
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM rocker/r-ver:4.1.2 | |||
| FROM rocker/r-ver:4.2.0 | |||
There was a problem hiding this comment.
Can we unpin from 4.2.0 so that we always test the latest version?
dbczumar
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
LGTM once https://github.com/mlflow/mlflow/pull/5763/files#r858116713 is addressed. Thanks @harupy !
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
dbczumar
pushed a commit
to dbczumar/mlflow
that referenced
this pull request
Apr 28, 2022
* install libharfbuzz-dev and libfribidi-dev Signed-off-by: harupy <hkawamura0130@gmail.com> * run Rscript --version Signed-off-by: harupy <hkawamura0130@gmail.com> * update Signed-off-by: harupy <hkawamura0130@gmail.com> * add comment Signed-off-by: harupy <hkawamura0130@gmail.com> * remove tolerance Signed-off-by: harupy <hkawamura0130@gmail.com> * clean up Signed-off-by: harupy <hkawamura0130@gmail.com> * use r-base:latest Signed-off-by: harupy <hkawamura0130@gmail.com> * use rocker/r-ver:latest Signed-off-by: harupy <hkawamura0130@gmail.com>
dbczumar
added a commit
to dbczumar/mlflow
that referenced
this pull request
Apr 28, 2022
Fix `r` job broken by R 4.2.0 (mlflow#5763)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy hkawamura0130@gmail.com
What changes are proposed in this pull request?
Fix
rjob broken by R 4.2.0:https://github.com/mlflow/mlflow/runs/6138928272?check_suite_focus=true#step:8:2475
How is this patch tested?
Existing tests
Does this PR change the documentation?
ci/circleci: build_doccheck. If it's successful, proceed to thenext step, otherwise fix it.
Detailson the right to open the job page of CircleCI.Artifactstab.docs/build/html/index.html.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes