-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge large-requirements.txt
and small-requirements.txt
#5942
Conversation
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Required for testing utilities for parsing pip requirements | ||
pip>=20.1 | ||
scipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scipy is now part of a module dependency and doesn't need explicit install with the changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great simplification!
* remove large-requirements.txt Signed-off-by: harupy <hkawamura0130@gmail.com> * rename Signed-off-by: harupy <hkawamura0130@gmail.com> * Remove large-requirements.txt Signed-off-by: harupy <hkawamura0130@gmail.com> * fix env vars Signed-off-by: harupy <hkawamura0130@gmail.com> * remove scipy Signed-off-by: harupy <hkawamura0130@gmail.com> * remove pyspark in test-requirements Signed-off-by: harupy <hkawamura0130@gmail.com> * install pyspark in pyfunc job Signed-off-by: harupy <hkawamura0130@gmail.com> * remove redundant env var Signed-off-by: harupy <hkawamura0130@gmail.com> * fix skinny job Signed-off-by: harupy <hkawamura0130@gmail.com> * fix typo Signed-off-by: harupy <hkawamura0130@gmail.com> * fix comment Signed-off-by: harupy <hkawamura0130@gmail.com>
) * remove large-requirements.txt Signed-off-by: harupy <hkawamura0130@gmail.com> * rename Signed-off-by: harupy <hkawamura0130@gmail.com> * Remove large-requirements.txt Signed-off-by: harupy <hkawamura0130@gmail.com> * fix env vars Signed-off-by: harupy <hkawamura0130@gmail.com> * remove scipy Signed-off-by: harupy <hkawamura0130@gmail.com> * remove pyspark in test-requirements Signed-off-by: harupy <hkawamura0130@gmail.com> * install pyspark in pyfunc job Signed-off-by: harupy <hkawamura0130@gmail.com> * remove redundant env var Signed-off-by: harupy <hkawamura0130@gmail.com> * fix skinny job Signed-off-by: harupy <hkawamura0130@gmail.com> * fix typo Signed-off-by: harupy <hkawamura0130@gmail.com> * fix comment Signed-off-by: harupy <hkawamura0130@gmail.com> Signed-off-by: Michal Karzynski <michal.karzynski@intel.com>
Related Issues/PRs
Follow-up for #5938
What changes are proposed in this pull request?
Merge
large-requirements.txt
andsmall-requirements.txt
into a single file.How is this patch tested?
Existing tests
Does this PR change the documentation?
ci/circleci: build_doc
check. If it's successful, proceed to thenext step, otherwise fix it.
Details
on the right to open the job page of CircleCI.Artifacts
tab.docs/build/html/index.html
.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes