Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields lost from squeezed output if DP not present in input #26

Closed
RussellTaylor opened this issue Jan 4, 2022 · 3 comments
Closed

Comments

@RussellTaylor
Copy link

I've been testing out spVCF with our product, the latest iteration of which is not writing the DP field. It's not fully clear to me from the spec whether DP is considered a mandatory field for squeezing, though there is an implication that it is. However, in the code its absence is handled except in one place: line 511 of spVCF.cc, where the loop starts from an index of 2 (i.e. assuming DP & GT are present), thus failing to write out one of the other fields.

The code should be updated to either explicitly reject input missing DP, or to handle its absence at the highlighted line.

mlin added a commit that referenced this issue Jan 7, 2022
#26 @RussellTaylor

Incidental maintenance:
- bump target architecture from Ivy Bridge to Haswell
- bump htslib and libdeflate
@mlin
Copy link
Owner

mlin commented Jan 7, 2022

Thanks for reporting! I put a probable fix on the main branch, will cut a release v1.1.1 once I use the opportunity to modernize the GitHub build a little.

@mlin
Copy link
Owner

mlin commented Jan 7, 2022

@RussellTaylor Please check if v1.2.0 fixes the problem, thanks

@RussellTaylor
Copy link
Author

@mlin Yes, that has fixed the issue of lost info that I was seeing. Thanks for addressing this so promptly!

@mlin mlin closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants