You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been testing out spVCF with our product, the latest iteration of which is not writing the DP field. It's not fully clear to me from the spec whether DP is considered a mandatory field for squeezing, though there is an implication that it is. However, in the code its absence is handled except in one place: line 511 of spVCF.cc, where the loop starts from an index of 2 (i.e. assuming DP & GT are present), thus failing to write out one of the other fields.
The code should be updated to either explicitly reject input missing DP, or to handle its absence at the highlighted line.
The text was updated successfully, but these errors were encountered:
Thanks for reporting! I put a probable fix on the main branch, will cut a release v1.1.1 once I use the opportunity to modernize the GitHub build a little.
I've been testing out spVCF with our product, the latest iteration of which is not writing the DP field. It's not fully clear to me from the spec whether DP is considered a mandatory field for squeezing, though there is an implication that it is. However, in the code its absence is handled except in one place: line 511 of spVCF.cc, where the loop starts from an index of 2 (i.e. assuming DP & GT are present), thus failing to write out one of the other fields.
The code should be updated to either explicitly reject input missing DP, or to handle its absence at the highlighted line.
The text was updated successfully, but these errors were encountered: