Create the screenshot directory even if nothing writes a screenshot #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding cleaning of special characters adding shortening on long desc name fix getting screenshots upon multiple failures
fix removal of creation of directory
…as the report needs it
Create the screenshot directory even if nothing writes a screenshot, …
|
This would be handy |
|
oh, sorry I didn't notice this one. Could you please rebase from master? |
|
@Juandeldesierto are you planning on rebasing this any time soon? It would be great to have this fix in. |
|
not planning to
2017-05-04 19:56 GMT+02:00 Eric Perry <notifications@github.com>:
… @Juandeldesierto <https://github.com/Juandeldesierto> are you planning on
rebasing this any time soon? It would be great to have this fix in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOoYywKukA_y-DbIughTB3fw52yJMusRks5r2hEzgaJpZM4JbduG>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due error
ENOENT: no such file or directory, open 'target/screenshots/report.html'
[chrome ANY #1-2] at Error (native)
[chrome ANY #1-2] at Object.fs.openSync (fs.js:640:18)
[chrome ANY #1-2] at Object.fs.writeFileSync (fs.js:1333:33)
[chrome ANY #1-2] at Object.fs.appendFileSync (fs.js:1392:6)
[chrome ANY #1-2] at Jasmine2ScreenShotReporter.jasmineDone (/var/lib/jenkins/workspace/PerModulePipeline-GavinTest/unified-analytics/node_modules/protractor-jasmine2-screenshot-reporter/index.js:500:10)
[chrome ANY #1-2] at dispatch (/var/lib/jenkins/workspace/PerModulePipeline-GavinTest/unified-analytics/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1966:28)
[chrome ANY #1-2] at ReportDispatcher.jasmineDone (/var/lib/jenkins/workspace/PerModulePipeline-GavinTest/unified-analytics/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1949:11)
[chrome ANY #1-2] at /var/lib/jenkins/workspace/PerModulePipeline-GavinTest/unified-analytics/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:758:18
[chrome ANY #1-2] at QueueRunner.clearStack (/var/lib/jenkins/workspace/PerModulePipeline-GavinTest/unified-analytics/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:660:9)
[chrome ANY #1-2] at QueueRunner.run (/var/lib/jenkins/workspace/PerModulePipeline-GavinTest/unified-analytics/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1881:12)