fix: Matrix and Lu circular dependency

Author: targos

src/abstractMatrix.js

@@ -1535,7 +1535,7 @@ function abstractMatrix(superCtor) {
                     return a * subMatrix0.det() - b * subMatrix1.det() + c * subMatrix2.det();
                 } else {
                     // general purpose determinant using the LU decomposition
-                    return new LuDecomposition(this, {skipCheck: true}).determinant;
+                    return new LuDecomposition(this).determinant;
                 }
 
             } else {

src/dc/cholesky.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var Matrix = require('../matrix');
+var Matrix = require('../matrix').Matrix;
 
 // https://github.com/lutzroeder/Mapack/blob/master/Source/CholeskyDecomposition.cs
 function CholeskyDecomposition(value) {

src/dc/evd.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const Matrix = require('../matrix');
+const Matrix = require('../matrix').Matrix;
 const util = require('./util');
 const hypotenuse = util.hypotenuse;
 const getFilled2DArray = util.getFilled2DArray;

src/dc/lu.js

@@ -3,16 +3,12 @@
 var Matrix = require('../matrix');
 
 // https://github.com/lutzroeder/Mapack/blob/master/Source/LuDecomposition.cs
-function LuDecomposition(matrix, options) {
+function LuDecomposition(matrix) {
     if (!(this instanceof LuDecomposition)) {
         return new LuDecomposition(matrix);
     }
 
-    options = options || {};
-
-    if (!options.skipCheck) {
-        matrix = Matrix.checkMatrix(matrix);
-    }
+    matrix = Matrix.Matrix.checkMatrix(matrix);
 
     var lu = matrix.clone(),
         rows = lu.rows,
@@ -103,7 +99,7 @@ LuDecomposition.prototype = {
         var data = this.LU,
             rows = data.rows,
             columns = data.columns,
-            X = new Matrix(rows, columns);
+            X = new Matrix.Matrix(rows, columns);
         for (var i = 0; i < rows; i++) {
             for (var j = 0; j < columns; j++) {
                 if (i > j) {
@@ -121,7 +117,7 @@ LuDecomposition.prototype = {
         var data = this.LU,
             rows = data.rows,
             columns = data.columns,
-            X = new Matrix(rows, columns);
+            X = new Matrix.Matrix(rows, columns);
         for (var i = 0; i < rows; i++) {
             for (var j = 0; j < columns; j++) {
                 if (i <= j) {
@@ -137,7 +133,7 @@ LuDecomposition.prototype = {
         return this.pivotVector.slice();
     },
     solve: function (value) {
-        value = Matrix.checkMatrix(value);
+        value = Matrix.Matrix.checkMatrix(value);
 
         var lu = this.LU,
             rows = lu.rows;

src/dc/qr.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var Matrix = require('../matrix');
+var Matrix = require('../matrix').Matrix;
 var hypotenuse = require('./util').hypotenuse;
 
 //https://github.com/lutzroeder/Mapack/blob/master/Source/QrDecomposition.cs

src/dc/svd.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var Matrix = require('../matrix');
+var Matrix = require('../matrix').Matrix;
 var util = require('./util');
 var hypotenuse = util.hypotenuse;
 var getFilled2DArray = util.getFilled2DArray;

src/decompositions.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var Matrix = require('./matrix');
+var Matrix = require('./matrix').Matrix;
 
 var SingularValueDecomposition = require('./dc/svd');
 var EigenvalueDecomposition = require('./dc/evd');

src/index.js

@@ -1,4 +1,4 @@
 'use strict';
 
-module.exports = require('./matrix');
+module.exports = require('./matrix').Matrix;
 module.exports.Decompositions = module.exports.DC = require('./decompositions');

src/matrix.js

@@ -137,5 +137,5 @@ class Matrix extends abstractMatrix(Array) {
     }
 }
 
-module.exports = Matrix;
+exports.Matrix = Matrix;
 Matrix.abstractMatrix = abstractMatrix;

src/views/base.js

@@ -1,7 +1,7 @@
 'use strict';
 
 var abstractMatrix = require('../abstractMatrix');
-var Matrix;
+var Matrix = require('../matrix');
 
 class BaseView extends abstractMatrix() {
     constructor(matrix, rows, columns) {
@@ -12,10 +12,7 @@ class BaseView extends abstractMatrix() {
     }
 
     static get [Symbol.species]() {
-        if (!Matrix) {
-            Matrix = require('../matrix');
-        }
-        return Matrix;
+        return Matrix.Matrix;
     }
 }