Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.table Depends -> Imports #246

Merged
merged 2 commits into from
Sep 21, 2019
Merged

data.table Depends -> Imports #246

merged 2 commits into from
Sep 21, 2019

Conversation

MichaelChirico
Copy link
Contributor

Thanks for using data.table! We noticed you are Depending on us and recently decided to strongly discourage downstream packages from doing so -- we think Imports is always better.

This PR attempts to make the migration from Depends to Imports for data.table.

If you have a strong reason for preferring Depends, we'd love to hear it over at our issue tracker:

Rdatatable/data.table#3076

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 87.488% when pulling fe76d4a on MichaelChirico:dt_import into ed75f69 on mllg:master.

@mllg mllg merged commit b54f00b into mllg:master Sep 21, 2019
@mllg
Copy link
Owner

mllg commented Sep 21, 2019

Thanks for the PR. I'll try to release a new version within in the next 4 weeks.

@MichaelChirico MichaelChirico deleted the dt_import branch September 22, 2019 04:44
@MichaelChirico MichaelChirico restored the dt_import branch July 23, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants