Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc/protobuf: manually force the latest version #723

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Mar 24, 2023

Hi 👋,

This commit follows #633 ; protobuf and grpc are both impacted

@mlocati
Copy link
Owner

mlocati commented Mar 24, 2023

Could you amend the commit, by adding a new line containing Test: grpc, protobuf (as described in README)?

Also: this implies that we have to update the script every time a new version of grpc and protobuf is published... This is something that I'm reclutant to do (maintaining this project it's already rather time consuming)

@Gounlaf Gounlaf force-pushed the force-version-grpc-protobuf branch from 297aec8 to 1da34e3 Compare March 24, 2023 15:44
@Gounlaf
Copy link
Contributor Author

Gounlaf commented Mar 24, 2023

Could you amend the commit, by adding a new line containing Test: grpc, protobuf (as described in README)?

Done

Also: this implies that we have to update the script every time a new version of grpc and protobuf is published... This is something that I'm reclutant to do (maintaining this project it's already rather time consuming)

Yes... What I understand is there is no guarantee that protoc or grpc release will be published in a "linear" way, and we can't rely on PECL to give the latest version "correctly" (following semver)

  • I can update the script every time (not necessary in the same time) via PR; If it's not done here, I will have to do it on Docker images that consume your script... so I would rather do it here for everyone :)
  • I can try to create a "github action" that will update the script automatically by watching grpc/protobuf release.

@mlocati
Copy link
Owner

mlocati commented Mar 24, 2023

there is no guarantee that protoc or grpc release will be published in a "linear" way

The same is valid for any other package published on PECL.

The best solution would be what's described at protocolbuffers/protobuf#10619 (comment) (and I hope one day PECL will be able to mark a version as the last one, even if it has been uploaded before other versions).

@mlocati mlocati force-pushed the force-version-grpc-protobuf branch from 1da34e3 to 606dd10 Compare April 13, 2023 07:23
@mlocati mlocati merged commit 14919cf into mlocati:master Apr 13, 2023
mlocati added a commit that referenced this pull request Sep 6, 2023
Why we previously forced versions?
See #723

Why we don't need that anymore?
See php/web-pecl#92

Test: grpc, protobuf
@mlocati
Copy link
Owner

mlocati commented Sep 6, 2023

@Gounlaf Please remark that, thanks to php/web-pecl#92, we don't need to manually specify the versions of grpc/protobuf anymore (so, I don't have to do stuff like #728, #741, #744, #746, #747, #749, #756, #759, #773, #782, #785, #788, #793 anymore) - see #798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants