-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discord][Feature request] Show ID for deleted users #8
Comments
hopperelec
added a commit
to hopperelec/chat-analytics
that referenced
this issue
Dec 31, 2022
Closes issue mlomb#8 It might be useful to display the user ID of all users (probably only on hover, not inside the label as I've done here) but for now, to reduce data usage, I'm only storing the user ID for deleted users (and users with an avatar, since their ID was stored anyway). Since the user ID used to be stored as a string for avatars, but it is now stored separately, the file size might actually be lower (assuming you have more users with avatars than deleted users). I'm not good with design, so I have not applied any CSS to the ID, but it looks decent as it is.
mlomb
added a commit
that referenced
this issue
Jan 5, 2023
* Display User ID for deleted users Closes issue #8 It might be useful to display the user ID of all users (probably only on hover, not inside the label as I've done here) but for now, to reduce data usage, I'm only storing the user ID for deleted users (and users with an avatar, since their ID was stored anyway). Since the user ID used to be stored as a string for avatars, but it is now stored separately, the file size might actually be lower (assuming you have more users with avatars than deleted users). I'm not good with design, so I have not applied any CSS to the ID, but it looks decent as it is. * Removed some debug logging I know this isn't how you're supposed to debug, but it was supposed to be a quick look lol * reverted some changes and hide the discriminator if the user is deleted * set discriminator to undefined if the user is deleted instead of comparing strings every label render (my bad) Co-authored-by: Martín Lombardo <to@mlomb.me>
mlomb
added a commit
that referenced
this issue
Jan 25, 2023
* Display User ID for deleted users Closes issue #8 It might be useful to display the user ID of all users (probably only on hover, not inside the label as I've done here) but for now, to reduce data usage, I'm only storing the user ID for deleted users (and users with an avatar, since their ID was stored anyway). Since the user ID used to be stored as a string for avatars, but it is now stored separately, the file size might actually be lower (assuming you have more users with avatars than deleted users). I'm not good with design, so I have not applied any CSS to the ID, but it looks decent as it is. * Removed some debug logging I know this isn't how you're supposed to debug, but it was supposed to be a quick look lol * reverted some changes and hide the discriminator if the user is deleted * set discriminator to undefined if the user is deleted instead of comparing strings every label render (my bad) Co-authored-by: Martín Lombardo <to@mlomb.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Deleted users have duplicate usernames and discriminators but their user ID does not change so this can be used to still differentiate (and possibly identify) these users. For identification (such as if the report includes multiple guilds and you don't know which guild a user is from), it could be useful to just show this for all users. This doesn't need to be on display at all times and could just be something shown on hover (title attribute, which currently just shows the username) or when toggled.
The text was updated successfully, but these errors were encountered: