-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous integration #6
Comments
Hi,I would like to work on this issue.Thanks. |
Nice, let me know if you need any help. |
@zoq I went through the travis.yml file in the mlpack repo. What I observed is that the file would be mostly same for this repo right? |
Yes, we can remove the python part and the step for running the tests. |
So for the python part if i'm not wrong wrong the env: part of the code as well as the code which checks pip2 and pip3 are installed wont be needed right?
|
You are right about the python part, the test part is:
|
As suggested by you I removed those part of code from the file.But when i'm running the travis CI,my build is failing.
|
How does the travis file look like? Can you open a PR? |
I have created a PR.I will squash the commits at the end once my code runs correctly. |
My travis.yml build is successful now.Should I squash all the commits and send a PR? |
@zoq I'm thinking of integrating appveyor CI.If i'm not wrong the test script wont be needed right? |
I had one doubt. I cant seem to figure out in which line is the make command getting executed in appveyor.yml file |
You are right the test step isn't needed. |
so what does line 38 and 39 do?( - 7z a mlpack-windows-no-libs.zip "%APPVEYOR_BUILD_FOLDER%\build\Release*.exe") |
Line 38 and 39 creates an archive that contains the library and or executables. |
So basically i will be building both mlpack and model repo. And that archive would be needed to be created for both the libraries right? |
I think we don't have to create an archive for the models repo. |
ohh i see.Thank you |
I guess I need a little help.In the final step for cmake for the models repository,an error pops up saying that CmakeList.txt is not present even though it is.
Here's the error which is coming. |
Are you sure you are using the correct path, |
Yeah I guessed that too but where I'm getting confused is that for building mlpack repo, similar code has been written and there no error is there so why is it showing an error when i'm using almost same code to build the model repo? |
Not sure what the issue is, you could open a PR, or I guess another idea is to check the output with some |
I will open a PR first then. Also will writing cmake .. -G instead of cmake -G work ,like we compile it in linux? |
yes, this should work. |
To make sure the code builds it would be great if we could set up some continuous integration services:
Realistically we can adapt (remove the test execution/build step) https://github.com/mlpack/mlpack/blob/master/.appveyor.yml and https://github.com/mlpack/mlpack/blob/master/.travis.yml for this repository.
At the end if
works this should be fine for now.
The text was updated successfully, but these errors were encountered: