-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plot for calibration #402
Comments
Would you please look at this when you are healthy again? Maybe we can simply recode the ABEL plot in gglot? But give us some feedback what is in the 2 packages above and how you like it. |
Ok looked at both of them. I see no reason to limit this to binary classification except for the Hosmer-Lemeshow test. Is there a multiclass analogue? Or do we care about this at all? |
Thanks and welcome back!!! Generally, we would be happy to have plots/tests for the multiclass case, too. |
Here is a preliminary version. Let me know what you all think when you get a chance to play with it. |
Also if you all know of a way to get |
Thank you very much, Zach. About I played around a bit and this is my first try to simplify l. 43-73 with something that
I guess to be consistent we could again separate things into data generating and plotting functions. I have no experience with calibration curves and not yet a strong opinion about this. |
@giuseppec |
He does have experience |
Thanks @schiffner for the help. I thought about a smoother for the same reason. I will definitely separate into plot/generate functions and also appreciate the refactoring help. |
The gist is updated now. There is an optional smoother, separate plot/generate functions, and simpler code thanks to @schiffner. If the basic design is fine then I'll make this work with survival tasks and add a ggvis version of the plot function as well. If anyone has any nominations for other features from any of the above packages I'm all ears. |
Nice work. I have two "requests":
Z <- rnorm(10000)
table(Hmisc::cut2(Z, g = 10))
Regarding the smooth calibration curve, I have to read a little bit more about it. But I think it makes also sense to include them. |
Ok I found Optimal line will be optional and true by default. Ok sounds good on the smoother. |
I think can use |
I think I got the "rag" and the binning done in an appropriate way. Lars already merged it but if you anyone has any other suggestions I am happy to work on it some more. The ggvis version is going to take a bit more work. |
This has now been added to the tutorial (under advanced) as well. I think the issue can be closed unless there are objections. |
Thanks, closing this. |
We should think of adding 'calibration plots' to mlr. Two packages, where this is implemented are:
http://www.genabel.org/PredictABEL/plotCalibration.html
http://www.inside-r.org/packages/cran/caret/docs/xyplot.calibration
The text was updated successfully, but these errors were encountered: