[Model Monitoring] Fix parsing of default http target #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
parse_monitoring_stream_path()on MLRun CE deployment that has nokafkastream, we use the default http path of the monitoring stream function as the main endpoint for the monitoring events. This default value can be found undermlrun.mlconf.model_endpoint_monitoring.default_http_sink:http://nuclio-{project}-model-monitoring-stream.mlrun.svc.cluster.local:8080This PR fix the parsing function of that http value in which we enrich the project name within the http path.