Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImageBuilder] Fix config with requirements file #4491

Merged
merged 6 commits into from
Oct 25, 2023
Merged

[ImageBuilder] Fix config with requirements file #4491

merged 6 commits into from
Oct 25, 2023

Conversation

alonmr
Copy link
Member

@alonmr alonmr commented Oct 25, 2023

laurybueno
laurybueno approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@laurybueno laurybueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work, man!

theSaarco
theSaarco approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you please also add a default value to the requirements parameter in with_requirements() such that if all I want is to specify a req file, I won't have to pass the requirements as well?

@alonmr alonmr merged commit ef7bf07 into mlrun:development Oct 25, 2023
8 checks passed
@alonmr alonmr deleted the ML-4844 branch October 25, 2023 18:47
alonmr added a commit to alonmr/mlrun that referenced this pull request Oct 25, 2023
@alonmr
[ImageBuilder] Fix config with requirements file (mlrun#4491)
7d4df37 
(cherry picked from commit ef7bf07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSaarco theSaarco theSaarco approved these changes

@laurybueno laurybueno laurybueno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alonmr @laurybueno @theSaarco