Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Store] Fix constructor following refactor of to_dict() #5095

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[Feature Store] Fix constructor following refactor of to_dict() #5095

merged 1 commit into from
Feb 8, 2024

Conversation

gtopper
Copy link
Collaborator

@gtopper gtopper commented Feb 8, 2024 •
edited
Loading

#4702 changed the handling of empty list parameters, and they are now removed on serialization, resulting in the default parameter replacing them.

Fixes these system test failures:

FAILED tests/system/feature_store/test_feature_store.py::TestFeatureStore::test_ingest_and_query[True-local-None] - KeyError: None
FAILED tests/system/feature_store/test_feature_store.py::TestFeatureStore::test_ingest_and_query[True-local-time] - KeyError: None
FAILED tests/system/feature_store/test_feature_store.py::TestFeatureStore::test_ingest_and_query[True-dask-None] - KeyError: None
FAILED tests/system/feature_store/test_feature_store.py::TestFeatureStore::test_ingest_and_query[True-dask-time] - KeyError: None

@gtopper
[Feature Store] Fix constructor following refactor of to_dict()
6c66819 
mlrun#4702 changed the handling of empty list parameters, and they are now removed on serialization, resulting in the default parameter replacing them.
@gtopper gtopper requested a review from assaf758 February 8, 2024 12:42
@assaf758 assaf758 merged commit 7364658 into mlrun:development Feb 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assaf758 assaf758 assaf758 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtopper @assaf758