Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model Monitoring] Fix querying invocations metric by itself #5652

Merged
merged 4 commits into from
May 29, 2024
Merged

[Model Monitoring] Fix querying invocations metric by itself #5652

merged 4 commits into from
May 29, 2024

Conversation

gtopper
Copy link
Collaborator

@gtopper gtopper commented May 29, 2024 •
edited by jira bot
Loading

jond01
jond01 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@jond01 jond01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add a test for this without a significant effort - it will be worth it.

About the title - why "[Datastore]"?

@gtopper gtopper changed the title [Datastore] Fix querying invocations metric by itself [Model Monitoring] Fix querying invocations metric by itself May 29, 2024
@gtopper
Copy link
Collaborator Author

gtopper commented May 29, 2024 •
edited
Loading

Tested manually. Trying to add it to system test. Added a fix to the test in the meantime.

@gtopper gtopper merged commit 8629217 into mlrun:development May 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jond01 jond01 jond01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtopper @jond01