[Model Monitoring] Add rebuild_images param to enable_model_monitoring()
#5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jond01
approved these changes
Jun 13, 2024
mlrun/projects/project.py
Outdated
| @@ -2116,6 +2116,7 @@ def enable_model_monitoring( | |||
| *, | |||
| deploy_histogram_data_drift_app: bool = True, | |||
| wait_for_deployment: bool = False, | |||
| overwrite: bool = False, | |||
There was a problem hiding this comment.
Please add the overwrite argument also to the deploy_histogram_data_drift_app function.
There was a problem hiding this comment.
I think ׳e can add it in different pr, not sure we want to add this option to the user.
davesh0812
changed the title
overwrite param to enable_model_monitoring()rebuild_images param to enable_model_monitoring()
assaf758
requested changes
Jun 13, 2024
Co-authored-by: Assaf Ben-Amitai <Assaf_Ben_Amitai@mckinsey.com>
Co-authored-by: Assaf Ben-Amitai <Assaf_Ben_Amitai@mckinsey.com>
Co-authored-by: Assaf Ben-Amitai <Assaf_Ben_Amitai@mckinsey.com>
assaf758
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-6580