Multi-threaded code to upload the indicators into CRITs #88
Conversation
…. Still need to multithread it because it takes too long
|
Thanks for this, Paul! You think you can merge our current master back to your repo so this can be at least mergeable? |
|
working on it - didn't notice all the logging work and the new version of Paul Poputa-Clean On Tue, Oct 21, 2014 at 3:53 PM, Alex Pinto notifications@github.com
|
|
ok, give this a try. I did a quick test and it seems to have worked just fine with the merged changes. |
|
Cool! Thanks. I'll take it for a spin. Guess I need to stand up a CRITs instance 😀 |
| @@ -22,14 +22,14 @@ | |||
| parser.add_argument('--tiq-test', help="Output in tiq-test format", action="store_true") | |||
| args = parser.parse_args() | |||
|
|
|||
| possible_types = ['csv', 'CSV'] | |||
| possible_types = ['csv', 'json','crits'] | |||
There was a problem hiding this comment.
There is no JSON support yet, so having 'json' here is misleading. :)
|
Conceptually and architecturally I am ok with this. I am not sure if @technoskald wants to do actual testing with a CRITs instance, but this would be otherwise good to go. Paul, if you are interested, you could write a blog post that we can publish on https://mlsecproject.org/blog about this integration you developed. It could be helpful for others also, so let's put the word out there! |
|
I'd love to write up a bit about the integration. How would i go about
|
|
I'll send you an e-mail about it. Thanks! |
Multi-threaded code to upload the indicators into CRITs
commented some of the functions, added the code to upload the indicators to CRITs with some parallel request capabilities (to maybe be replaced by grequests), and changed some of the code in combine.py to make it case-insensitive in the parsing of command line parameters.