Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Session manager to singleton #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactored Session manager to singleton #95

wants to merge 1 commit into from

Conversation

kralmichal
Copy link

Issue #84

Copy link
Owner

@mluzarow mluzarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello kralmichal; thank you for taking the time to contribute to this little project! There are a couple things I have issue with in this pull request. One being that your editor seems to have automatically truncated the tabbing from all lines that do not have code on them; this is a minor issue but if you could remain consistent with the existing style of the code files in the project, I, and any other repo owner that you contribute to, would be very appreciative.

Additionally, you made changes to the code style, which again goes back to my above point of not staying consistent with the existing style of the existing codebase.

@kralmichal
Copy link
Author

So sorry I will fix the issues.

Have you considered having .editorconfig file in the root of your project? https://editorconfig.org/
It'll prevent this sort of things from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants