Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lr_finder #59

Merged
merged 8 commits into from
Aug 11, 2021
Merged

add lr_finder #59

merged 8 commits into from
Aug 11, 2021

Conversation

cmcmaster1
Copy link
Contributor

No description provided.

@dfalbel
Copy link
Member

dfalbel commented Aug 10, 2021

Thanks very much @cmcmaster1 !

I changed a little the API for plotting, instead of the plot = TRUE argument we now have an S3 method for the result of lr_finder. This way its easier to change the plot location and/or save it to a file.

Also added a small test case. I still want to add an example to the docs and then we are good to merge!

@cmcmaster1
Copy link
Contributor Author

Yeah, I certainly wasn't sold on my implementation. This makes sense.

@dfalbel dfalbel merged commit 911db44 into mlverse:master Aug 11, 2021
@cmcmaster1 cmcmaster1 deleted the lr-finder branch August 12, 2021 01:12
@dfalbel dfalbel mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants