Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloning): metadata, finalizer, and repeated cloning #1134

Merged
merged 28 commits into from
Feb 20, 2024
Merged

fix(cloning): metadata, finalizer, and repeated cloning #1134

merged 28 commits into from
Feb 20, 2024

Commits on Feb 7, 2024

  1. fix(Tensor): cloning preserves attributes

    @sebffischer
    sebffischer committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    aa418c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. fix(tensor): clone preserves requires_grad

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0dfa9f3 View commit details
    Browse the repository at this point in the history

  2. news

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4b701d2 View commit details
    Browse the repository at this point in the history

  3. fix previos commit and fix nn-module's clone

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a744a65 View commit details
    Browse the repository at this point in the history

  4. news

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4ec08fd View commit details
    Browse the repository at this point in the history

  5. fix previous commit

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7882cb9 View commit details
    Browse the repository at this point in the history

  6. remove unneeded comment

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b0ae5f4 View commit details
    Browse the repository at this point in the history

  7. fix(tensor): cloning left BackwardClone in grad_fn

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    39dab3e View commit details
    Browse the repository at this point in the history

  8. fix(Module): clone works after () / ()

    @sebffischer
    sebffischer committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8d3ca4b View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. CloneBackward requires for cloning of tensor

    @sebffischer
    sebffischer committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1a30d71 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. support clone finalizer and fix repeated cloning issue

    @sebffischer
    sebffischer committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    fa1971b View commit details
    Browse the repository at this point in the history

  2. fix: cloning of child modules 

    stills needs some cleanup but in principle it should be working
    @sebffischer
    sebffischer committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    22bc164 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. fix: various cloning issues

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7c8eafc View commit details
    Browse the repository at this point in the history

  2. remove unneeded import

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    2a0bc34 View commit details
    Browse the repository at this point in the history

  3. fix and rename finalize_clone method

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3ddfe1d View commit details
    Browse the repository at this point in the history

  4. fix some previously introduced issues

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    11599d2 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @sebffischer
    sebffischer authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    720b895 View commit details
    Browse the repository at this point in the history

  6. remove leftover line

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a528a82 View commit details
    Browse the repository at this point in the history

  7. insert whitespace in printer

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e3af56d View commit details
    Browse the repository at this point in the history

  8. cleanup snapshot files

    @sebffischer
    sebffischer committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    cd1c358 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. fix: cloning now works outside the toch package as well 

    the encapsulation of the patched clone method of the nn_module
caused private functions like xptr_address to be inaccessible
    @sebffischer
    sebffischer committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    b791f42 View commit details
    Browse the repository at this point in the history

  2. clarify comment

    @sebffischer
    sebffischer committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3c7148d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge branch 'main' into fix/cloning

    @dfalbel
    dfalbel authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d4dab9b View commit details
    Browse the repository at this point in the history

  2. Rename to clone.

    @dfalbel
    dfalbel committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    bbb1a5b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/cloning' of https://github.com/sebffischer/torch in… 

    …to pr/sebffischer/1134
    @dfalbel
    dfalbel committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    f6bdad2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. refactor: remove unneeded code

    @sebffischer
    sebffischer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ff505ce View commit details
    Browse the repository at this point in the history

  2. refactor clone method

    @sebffischer
    sebffischer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    87ad38d View commit details
    Browse the repository at this point in the history

  3. fix refactor

    @sebffischer
    sebffischer committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5c5b2d6 View commit details
    Browse the repository at this point in the history