Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved health sample support, significant refactor of CLI, server and parsing code #3

Merged
merged 33 commits into from
Apr 17, 2021
Merged

Improved health sample support, significant refactor of CLI, server and parsing code #3

merged 33 commits into from
Apr 17, 2021

Conversation

mm
Copy link
Owner

@mm mm commented Apr 17, 2021

Lots of changes in here to prep for the next Heartbridge release, the major ones being:

  • Adds support for pretty much any data record in the Health app, with nice formatting and exporting for Heart Rate, Resting Heart Rate, Heart Rate Variability, Flights Climbed, Steps, and Cycling distance (will require a new iOS Shortcut to be installed)
  • Backwards-compatible with Heartbridge 1 shortcut which only supported heart rate
  • Switches the built-in server to use Starlette and Uvicorn, adding dependencies but allowing testing to get much better
  • Switches to Click for the CLI to simplify validation code and improve cross-platform support
  • Reworked parsing code that can be extended much more easily to support more data types in the future, and can be used independently of the CLI for other applications like pushing to a database

mm added 24 commits March 27, 2021 12:43
@mm
added data classes for heart rate, steps and flights
77f7af1
@mm
added generator for heart rate readings (test)
acdac8c
@mm
generalized generator
8d54177
@mm
added field names to BaseHealthReading, started new exporter classes
20d6ccf
@mm
added JSON importer, and split helper methods into correct modules
162b7d2
@mm
adds legacy check and warning for old data format
5df4d79
@mm
added in record type checking to health module, and made module compa…
4373eed 
…tible with Shortcuts health record type naming
@mm
fixed legacy field mapping
2c04184
@mm
switched to using starlette+uvicorn for HTTP handling
d9aba7b
@mm
moved value mapping over to data classes
48bd6c3
@mm
Adds GenericHealthReading to cover any time-series health record type
e2c582d
@mm
switched to using click for CLI definition, moved vopt validation to …
50e3dc5 
…click
@mm
moved data processing into endpoint
ddb6abb
@mm
added more specific exception classes, and moved file checks to click
3cf19e2
@mm
moved health and export module tests to pytest and improved tempfile …
557f54e 
…handling
@mm
started unit endpoint tests
32ddf23
@mm
more endpoint testing, and adds RHR, HRV, cycling distance metrics
4e4ccec
@mm
added endpoint tests for each kind of new input
437362b
@mm
made CLI a little friendlier
83bbf77
@mm
updates pipfile, and switches to GitHub Actions for testing
27a7536
@mm
adding workflow runs everywhere
866a807
@mm
made pytest run in a pipenv shell for GH actions
7fce8f3
@mm
began new documentation
be45128
@mm
refactored more to_dict into BaseHealthReading, relying on a class va…
f82c43f 
…riable defined for each subclass for dict keys
@mm mm linked an issue Apr 17, 2021 that may be closed by this pull request
Other Health Data? #2
Closed
@mm mm merged commit 2045203 into main Apr 17, 2021
@mm mm deleted the feature/new-datatypes branch April 17, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Other Health Data?
1 participant
@mm