Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting until Internet Explorer process being debugged has exited before continuing when using the web server #802

Merged
merged 2 commits into from
Jun 20, 2021

Conversation

icnocop
Copy link
Contributor

@icnocop icnocop commented Jun 5, 2021

Added IEBrowserTabOpenTimeout setting
Fixed typos
Waiting until Internet Explorer process being debugged has exited before continuing when using the web server
Using Microsoft.VisualStudio.Shell.14 nuget package
Using Microsoft.VSSDK.BuildTools.15.0.26201 released nuget package
Fixes #787

Fixed typos
Waiting until Internet Explorer process being debugged has exited before continuing when using the web server
Using Microsoft.VisualStudio.Shell.14 nuget package
Using Microsoft.VSSDK.BuildTools.15.0.26201 released nuget package
Fixes mmanela#787
@mmanela
Copy link
Owner

mmanela commented Jun 5, 2021

This is a great PR. Some questions/comments

  1. Wow, thanks for the typo fixes. That is quite embarrassing ;)
  2. What versions of VS did you test this on? (Do you know if the upgrades / additions on the nuget packages will affect version compatibility?)

@icnocop
Copy link
Contributor Author

icnocop commented Jun 5, 2021

Thank you for the code review.

1. Wow, thanks for the typo fixes. That is quite embarrassing ;)

No worries. :)

2. What versions of VS did you test this on?  (Do you know if the upgrades / additions on the nuget packages will affect version compatibility?)

I built the code using Visual Studio 2017 and tested on Visual Studio 2019.

I don't think the upgrades should affect version compatibility because I kept the same major version.

Can the sample projects be open in older versions of Visual Studio and be used to test backwards compatibility?

@icnocop
Copy link
Contributor Author

icnocop commented Jun 5, 2021

Here is Chutzpah.VS2012.vsix built from this pull request, installing on another machine with Visual Studio 2015, 2017, and 2019 installed:

image

image

@icnocop
Copy link
Contributor Author

icnocop commented Jun 5, 2021

Here is the Test Explorer window in Visual Studio 2015:

image

image

@icnocop
Copy link
Contributor Author

icnocop commented Jun 17, 2021

Let me know if you'd like me to squash my commits into one.

@mmanela
Copy link
Owner

mmanela commented Jun 20, 2021

Its fine, sorry for the delay. I didn't have a window environment setup, just got a VM built and will take a look.

@mmanela
Copy link
Owner

mmanela commented Jun 20, 2021

Ok works! Thanks for the great PR

@mmanela mmanela merged commit f627853 into mmanela:master Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using Server Mode debug in Test Explorer does not work
2 participants