Rails 3.1 update_page #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t::fb_login_and_redirect
|
Why not merged yet ? Is there any problem ? |
|
I second this pull request. Fixes it right up for me in 3.1rc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rails 3.1 support for Facebooker2::Rails::Helpers::FacebookConnect::fb_login_and_redirect to answer Issue #51
It lets facebooker2 still use update_page when it can be used (before 3.1rc4)
Just a lil thing : I didn't wrote any spec for it as my skills don't allow me to do so yet. Hope te patch may be useful if someone specs it (I'll maybe take a look at it if I have more time)