Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor JDK8 cleanup and simplifications #47

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Minor JDK8 cleanup and simplifications #47

merged 2 commits into from
Dec 21, 2020

Conversation

dweiss
Copy link
Collaborator

@dweiss dweiss commented Dec 21, 2020

No description provided.

@dweiss dweiss mentioned this pull request Dec 21, 2020
Closed
mmastrac
mmastrac approved these changes Dec 21, 2020
View reviewed changes
Copy link
Owner

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we need a maven change as well to force v8?

@dweiss
Copy link
Collaborator Author

dweiss commented Dec 21, 2020

Ah, probably. I'll update in a sec.

@mmastrac
Copy link
Owner

LGTM +1!

@dweiss dweiss merged commit 4349800 into master Dec 21, 2020
@dweiss dweiss deleted the nits/jdk8 branch December 21, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweiss @mmastrac