Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP Headers to parser #144

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add HTTP Headers to parser #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3887fc
add headers to http call
albadraco May 3, 2020
80f0d78
add wrapper
albadraco May 3, 2020
6c90f23
update withheaders
albadraco Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ type HTTPError struct {
Status string
}

// HTTPHeaders represents the Headers to add to http request.
type HTTPHeaders map[string]string

func (err HTTPError) Error() string {
return fmt.Sprintf("http error: %s", err.Status)
}
Expand Down Expand Up @@ -104,12 +107,28 @@ func (f *Parser) ParseURL(feedURL string) (feed *Feed, err error) {
// It will be automatically added to the header of the request
// Request could be canceled or timeout via given context
func (f *Parser) ParseURLWithContext(feedURL string, ctx context.Context) (feed *Feed, err error) {
client := f.httpClient()
return f.ParseURLWithContextAndHeaders(feedURL, ctx, nil)
}

// ParseURLWithHeaders use default context and add headers.
func (f *Parser) ParseURLWithHeaders(feedURL string, headers HTTPHeaders) (feed *Feed, err error) {
return f.ParseURLWithContextAndHeaders(feedURL, context.Background(), headers)
}

// ParseURLWithContextAndHeaders include http headers in request
func (f *Parser) ParseURLWithContextAndHeaders(feedURL string, ctx context.Context, headers HTTPHeaders) (feed *Feed, err error) {
client := f.httpClient()

req, err := http.NewRequestWithContext(ctx, "GET", feedURL, nil)
if err != nil {
return nil, err
}
req = req.WithContext(ctx)

for _, k := range headers {
req.Header.Set(k, headers[k])
}

req.Header.Set("User-Agent", f.UserAgent)

if f.AuthConfig != nil && f.AuthConfig.Username != "" && f.AuthConfig.Password != "" {
Expand Down