Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrement Depth in DecodeElement() #4

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Decrement Depth in DecodeElement() #4

merged 1 commit into from
Oct 3, 2018

Conversation

cristoper
Copy link
Contributor

A test case and fix for what I think is a bug where the Depth field is not decremented after unmarshaling an element with DecodeElement() (Issue #3)

@cristoper
Decrement Depth in DecodeElement()
f6e336e 
A test case and fix for Issue #3
@coveralls
Copy link

Coverage Status

Coverage increased (+13.8%) to 55.508% when pulling f6e336e on cristoper:fixdepth into dd19db0 on mmcdole:master.

@mmcdole
Copy link
Owner

mmcdole commented Oct 3, 2018 •
edited
Loading

Thanks! Fixes #3

@mmcdole mmcdole merged commit e18b6e9 into mmcdole:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcdole mmcdole mmcdole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristoper @coveralls @mmcdole